[webkit-reviews] review granted: [Bug 122893] Web Inspector: Go to line keyboard command and dialog : [Attachment 214445] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 122893: Web Inspector: Go to line keyboard command and dialog
https://bugs.webkit.org/show_bug.cgi?id=122893

Attachment 214445: Patch
https://bugs.webkit.org/attachment.cgi?id=214445&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214445&action=review


> Source/WebInspectorUI/UserInterface/GoToLineDialog.js:26
> +WebInspector.GoToLineDialog = function()

I suspect in the future we might want to reuse this or inherit from a base
class to share code with Open Quickly.

> Source/WebInspectorUI/UserInterface/GoToLineDialog.js:41
> +    this._clearIcon = field.appendChild(document.createElement("img"));
> +    this._clearIcon.src = "Images/CloseWhite.svg";

We try to keep these paths in CSS. There isn't any reason this needs to be in
JS.

> Source/WebInspectorUI/UserInterface/GoToLineDialog.js:160
> +WebInspector.GoToLineDialog.prototype.__proto__ =
WebInspector.Object.prototype;

We should start putting __proto__ in the prototype object above next to
constructor. Brian Burg has started doing this in Timelapse code and it helps
readability and ties things together better.