[webkit-reviews] review denied: [Bug 121806] Initial implementation of text-decoration-skip ink : [Attachment 214375] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 121806: Initial implementation of text-decoration-skip ink
https://bugs.webkit.org/show_bug.cgi?id=121806

Attachment 214375: Patch
https://bugs.webkit.org/attachment.cgi?id=214375&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214375&action=review


Looks like you just missed the "AllInOne" file. r- to correct that.

> Source/JavaScriptCore/ChangeLog:8
> +	   * Configurations/FeatureDefines.xcconfig:

What's this all about?	Looks like a leftover ChangeLog

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:11634
> +	 <ExcludedFromBuild
Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFrom
Build>

If you mark it as "don't build" here, you need to add it to
"RenderingAllInOne.cpp"