[webkit-reviews] review denied: [Bug 122787] JavaScriptCore tests should run on Windows : [Attachment 214231] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 122787: JavaScriptCore tests should run on Windows
https://bugs.webkit.org/show_bug.cgi?id=122787

Attachment 214231: Patch
https://bugs.webkit.org/attachment.cgi?id=214231&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214231&action=review


The overall idea here is great, but your change would cause catastrophic
breaking of our internal build process so I must reject this patch.

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.submit.sln:44
> +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WTF",
"..\..\WTF\WTF.vcxproj\WTF.vcxproj", "{8EF73779-BED3-45BB-816D-9FF58399AFA5}"

You can't do this. WTF.submit.sln and JavaScriptCore.submit.sln are isolated
from each-other for a reason.

What you COULD do, is make sure there is a JavaScriptCore.sln that looks
exactly like this file, and have build-jsc use that file (instead of
JavaScriptCore.submit.sln).

> Source/WTF/WTF.vcxproj/WTF.submit.sln:-2
> -Microsoft Visual Studio Solution File, Format Version 11.00

Why are you removing this file?  It's critical.