[webkit-reviews] review denied: [Bug 122883] [WK2] Convert SeccompFilters to using unique_ptr instead of OwnPtr/PassOwnPtr : [Attachment 214340] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Sergio Correia
<sergio.correia at openbossa.org>'s request for review:
Bug 122883: [WK2] Convert SeccompFilters to using unique_ptr instead of
OwnPtr/PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122883

Attachment 214340: Patch
https://bugs.webkit.org/attachment.cgi?id=214340&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214340&action=review


Patch looks good, but please remove the unnecessary std::move calls.

> Source/WebKit2/Shared/linux/SeccompFilters/OpenSyscall.cpp:60
> +	   return std::move(open);

No need to use std::move here. Returning a move-only object will automatically
move the object.

> Source/WebKit2/Shared/linux/SeccompFilters/OpenSyscall.cpp:93
> +    return std::move(open);

Ditto.

> Source/WebKit2/Shared/linux/SeccompFilters/OpenSyscall.cpp:105
> +    return std::move(open);

Ditto.

> Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp:76
> +    return std::move(syscall);

Ditto.

> Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp:98
> +    return std::move(result);

Ditto.