[webkit-reviews] review denied: [Bug 122889] [EFL] accessibility/plugin.html passes incorrectly : [Attachment 214353] proposed patch 2

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has denied Andrzej Badowski
<a.badowski at samsung.com>'s request for review:
Bug 122889: [EFL] accessibility/plugin.html passes incorrectly
https://bugs.webkit.org/show_bug.cgi?id=122889

Attachment 214353: proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=214353&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
I've just quickly checked for uses of test.swf in the Layout tests directory
and found that is used in two more places other than accessibility:

$ git grep "resources/test.swf"
accessibility/plugin.html:	 <embed src="resources/test.swf"
type="application/x-shockwave-flash">
fast/loader/sandboxed-plugin-crash.html:<iframe src="resources/test.swf"
sandbox="allow-same-origin allow-forms allow-scripts"></iframe><br>
fast/replaced/border-radius-clip.html:<embed src="resources/test.swf"
style="border:3px solid black; background-color: lime; -webkit-border-radius:
32px; margin-bottom:-32px"
fast/replaced/embed-display-none.html:	<embed style="display:none"
src="resources/test.swf"

Additionally, I've also found that all the three different instances of
test.swf are actually the same file, duplicated in three different locations:

$ md5sum platform/mac/accessibility/resources/test.swf
fast/loader/resources/test.swf fast/replaced/resources/test.swf
140bd629879234796a2334c066a3b9e1  platform/mac/accessibility/resources/test.swf

140bd629879234796a2334c066a3b9e1  fast/loader/resources/test.swf
140bd629879234796a2334c066a3b9e1  fast/replaced/resources/test.swf

So, I think that instead of moving it from platform/mac/accessibility/resources
into accessibility/resources, it would be better to put it in
LayoutTests/resources/ and update the relative paths in those four tests.