[webkit-reviews] review granted: [Bug 122884] Flesh out the DatabaseProcess (and launch it!) : [Attachment 214341] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 122884: Flesh out the DatabaseProcess (and launch it!)
https://bugs.webkit.org/show_bug.cgi?id=122884

Attachment 214341: Patch v1 
https://bugs.webkit.org/attachment.cgi?id=214341&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214341&action=review


Seems reasonable to me.

> Source/WebCore/English.lproj/Localizable.strings:-39
> -/* Visible name of the shared worker process. The argument is the
application name. */
> -"%@ Shared Worker" = "%@ Shared Worker";
> -

Why don't we need this one anymore? Why doesn't the changelog say why not?

> Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.cpp:93
> +    // Grab the first pending connection reply.

Not sure this is a useful comment.

> Source/WebKit2/UIProcess/WebContext.cpp:423
> +    ASSERT(m_databaseProcess);

This seems unnecessary after an ensure()! At least, that's what ensure means :)
And otherwise you're just gonna crash below, so you don't need this.

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:56
> +    // FIXME: Access the connection to the DatabaseProcess to make sure it
has been created to assisted

To assisted?