[webkit-reviews] review denied: [Bug 122874] During editing, merge inline style with overriding other author styles : [Attachment 214327] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 15 19:14:12 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has denied KyungTae Kim <ktf.kim at samsung.com>'s
request for review:
Bug 122874: During editing, merge inline style with overriding other author
styles
https://bugs.webkit.org/show_bug.cgi?id=122874

Attachment 214327: Patch
https://bugs.webkit.org/attachment.cgi?id=214327&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214327&action=review


This patch needs a test case demonstrating it fixes a bug; at minimum it
shouldn't regress tests.

> Source/WebCore/ChangeLog:9
> +	   Inline styles need to override other author styles,
> +	   so if DoNotOverrideValues mode, inline styles need to be merged
before other author styles.

Why?


More information about the webkit-reviews mailing list