[webkit-reviews] review granted: [Bug 97516] [CMake] Remove support for cmake version < 2.8.3 : [Attachment 214255] Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 15 17:54:58 PDT 2013


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Afonso Costa
<afonso.costa at samsung.com>'s request for review:
Bug 97516: [CMake] Remove support for cmake version < 2.8.3
https://bugs.webkit.org/show_bug.cgi?id=97516

Attachment 214255: Patch v3
https://bugs.webkit.org/attachment.cgi?id=214255&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214255&action=review


I checked this patch can check if higher version is required. However, Ryuan
might want to have a final look before landing.

> ChangeLog:3
> +	   [CMAKE] Update code to take advantage of CMake version 2.8.3+.

Please sync with this bug title before landing. It looks this one is better
than this bug title.


More information about the webkit-reviews mailing list