[webkit-reviews] review granted: [Bug 122861] Baseline JIT should use the DFG GetById IC : [Attachment 214323] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 122861: Baseline JIT should use the DFG GetById IC
https://bugs.webkit.org/show_bug.cgi?id=122861

Attachment 214323: the patch
https://bugs.webkit.org/attachment.cgi?id=214323&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214323&action=review


wow, that is a lot of red

> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:473
>      BEGIN_UNINTERRUPTED_SEQUENCE(sequenceGetByIdHotPath);

Remove this -- you've removed the corresponding end.  Maybe worth just having
an initial patch remove the *_UNINTERRUPTED_* macros -- assuming the patchable
jump/label logic is handling everything correctly we no long reed to worry
about inline constant pools breaking repatching.