[webkit-reviews] review granted: [Bug 122773] Add a PlatformCALayer subclass that proxies its property changes across the process boundary : [Attachment 214313] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 122773: Add a PlatformCALayer subclass that proxies its property changes
across the process boundary
https://bugs.webkit.org/show_bug.cgi?id=122773

Attachment 214313: patch
https://bugs.webkit.org/attachment.cgi?id=214313&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214313&action=review


> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:85
> +	   const RemoteLayerTreeTransaction::LayerProperties& properties =
changedLayer.value;

Can use const auto& here.

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:116
> +	       NSMutableArray *children = [[NSMutableArray alloc] init];

I believe you’re leaking this array here. Also, I think you can
initWithCapacity.

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:132
> +	   layer.get().style = @{ @"actions" : nullActionsDictionary() };

I think you should use [layer setStyle:] here.

> Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.h:61
> +

Extra newline here.

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:140
> +

Extra newline.