[webkit-reviews] review requested: [Bug 122864] GetGenerateIsReachable=ImplContext is confusing : [Attachment 214301] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 15 14:45:51 PDT 2013


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 122864: GetGenerateIsReachable=ImplContext is confusing
https://bugs.webkit.org/show_bug.cgi?id=122864

Attachment 214301: proposed patch
https://bugs.webkit.org/attachment.cgi?id=214301&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Alternatively, we could use an auto variable to hold the context, and make it
work with any classes that have a context() method (as long as the context is
registered as an opaque root).

Not sure if that's desirable - there is no JS concept of "context", so tying it
too deeply into generated code may be misleading. We already have bare
"GenerateIsReachable" for those who prefer a universal mechanism.


More information about the webkit-reviews mailing list