[webkit-reviews] review granted: [Bug 122849] Add a skeleton Database process for future usage by IDB and Web SQL : [Attachment 214290] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 15 13:55:38 PDT 2013


Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 122849: Add a skeleton Database process for future usage by IDB and Web SQL
https://bugs.webkit.org/show_bug.cgi?id=122849

Attachment 214290: Patch v1 
https://bugs.webkit.org/attachment.cgi?id=214290&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214290&action=review


>
Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Develo
pment/Info.plist:30
> +	<key>NSPrincipalClass</key>
> +	<string>NSApplication</string>

I am not sure you want this.

>
Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Develo
pment/Info.plist:36
> +		<key>JoinExistingSession</key>
> +		<true/>

I am not sure you need this.

>
Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.p
list:28
> +	<key>NSPrincipalClass</key>
> +	<string>NSApplication</string>

Do you need this?

>
Source/WebKit2/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.p
list:36
> +		<key>JoinExistingSession</key>
> +		<true/>

Do you need this?


More information about the webkit-reviews mailing list