[webkit-reviews] review granted: [Bug 122762] [iOS] Upstream JavaScriptCore support for ARM64 : [Attachment 214210] Offlineasm changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 15 11:21:28 PDT 2013


Filip Pizlo <fpizlo at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 122762: [iOS] Upstream JavaScriptCore support for ARM64
https://bugs.webkit.org/show_bug.cgi?id=122762

Attachment 214210: Offlineasm changes
https://bugs.webkit.org/attachment.cgi?id=214210&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214210&action=review


> Source/JavaScriptCore/offlineasm/x86.rb:49
> -class SpecialRegister < NoChildren
> +class SpecialRegister

I think you want to revert this.  It looks like a bug fix that landed on trunk
but that was reverted by accident in our ARM64 work.  Also, it has nothing to
do with arm64 - this is in the x86 file.


More information about the webkit-reviews mailing list