[webkit-reviews] review denied: [Bug 122617] transition void cti_op_* methods to JIT operations. : [Attachment 214265] With fixes Mark suggested

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 122617: transition void cti_op_* methods to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122617

Attachment 214265: With fixes Mark suggested
https://bugs.webkit.org/attachment.cgi?id=214265&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214265&action=review


> Source/JavaScriptCore/jit/CCallHelpers.h:1096
> +	   poke(arg4, POKE_ARGUMENT_OFFSET);

Will this poke be valid when we're running on the C stack? Will each stack
frame reserve space for these pokes?

> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1185
> +    callOperation(operationProfileWillCall, regT1, regT0);

Wrong function = broken profiler. Did the profiler tests pass for this patch?