[webkit-reviews] review requested: [Bug 122142] Release expired pages in the page cache more often : [Attachment 214238] Patch using a timer in PageCache, avoids changing public method signature

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 15 00:14:27 PDT 2013


Iago Toral <itoral at igalia.com> has asked  for review:
Bug 122142: Release expired pages in the page cache more often
https://bugs.webkit.org/show_bug.cgi?id=122142

Attachment 214238: Patch using a timer in PageCache, avoids changing public
method signature
https://bugs.webkit.org/attachment.cgi?id=214238&action=review

------- Additional Comments from Iago Toral <itoral at igalia.com>
I don't know why the Mac build fails with the previous patch but I guess it is
related with the fact that the patch changes the signature of the public remove
method to add a parameter with a default value. This new patch keeps the
original method and adds a private version that takes the additional argument.
Hopefully this will fix the build problem on Mac.


More information about the webkit-reviews mailing list