[webkit-reviews] review granted: [Bug 122802] Don't generate a wasteful isObservable check in isReachableFromOpaqueRoots : [Attachment 214215] a little better

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 122802: Don't generate a wasteful isObservable check in
isReachableFromOpaqueRoots
https://bugs.webkit.org/show_bug.cgi?id=122802

Attachment 214215: a little better
https://bugs.webkit.org/attachment.cgi?id=214215&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214215&action=review


r=me

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2575
> +	       push(@implContent, "    JS${interfaceName}* js${interfaceName} =
jsCast<JS${interfaceName}*>(handle.get().asCell());\n");
> +	       $emittedJSCast = 1;

Might want to check if (!$emittedJSCast) for future people to pick up on the
pattern if they add something. Up to you though.