[webkit-reviews] review granted: [Bug 122776] Crash in WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>::createBidiRunsForLine : [Attachment 214185] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 14 16:02:55 PDT 2013


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 122776: Crash in WebCore::BidiResolver<WebCore::InlineIterator,
WebCore::BidiRun>::createBidiRunsForLine
https://bugs.webkit.org/show_bug.cgi?id=122776

Attachment 214185: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=214185&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214185&action=review


> Source/WebCore/ChangeLog:29
> +	   While looking at the code, I also discovered we used INT_MAX as a
magic value
> +	   for a midpoint's position, but the variable is actually an unsigned.
I changed
> +	   the magic value to be UINT_MAX.

I don’t see this change.


More information about the webkit-reviews mailing list