[webkit-reviews] review granted: [Bug 84398] Move LayoutTestController::setValueForUser to Internals : [Attachment 214182] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andre Loureiro (IRC: loureiro)
<andre.vl at samsung.com>'s request for review:
Bug 84398: Move LayoutTestController::setValueForUser to Internals
https://bugs.webkit.org/show_bug.cgi?id=84398

Attachment 214182: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=214182&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks like Windows needs an update to an .exp file:

     1>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved
external symbol "public: void __thiscall
WebCore::HTMLInputElement::setValueForUser(class WTF::String const &)"
(?setValueForUser at HTMLInputElement@WebCore@@QAEXABVString at WTF@@@Z) referenced
in function "public: void __thiscall WebCore::Internals::setValueForUser(class
WebCore::Element *,class WTF::String const &,int &)"
(?setValueForUser at Internals@WebCore@@QAEXPAVElement at 2@ABVString at WTF@@AAH at Z)

r=me as long as you fix that