[webkit-reviews] review granted: [Bug 122774] Windows popup menu does not reselect last selected index when clicking on a disabled option : [Attachment 214183] patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 122774: Windows popup menu does not reselect last selected index when
clicking on a disabled option
https://bugs.webkit.org/show_bug.cgi?id=122774

Attachment 214183: patch
https://bugs.webkit.org/attachment.cgi?id=214183&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=214183&action=review


Looks good to me. I wonder if we will mess up WINCE at all with the movement of
the "setFocusedIndex" logic to inside the #if !OS(WINCE) block.

> Source/WebCore/platform/win/PopupMenuWin.cpp:167
> +    }

Do you think this block is needed by WINCE?