[webkit-reviews] review granted: [Bug 122762] [iOS] Upstream JavaScriptCore support for ARM64 : [Attachment 214165] Assembler and disassembler changes

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 122762: [iOS] Upstream JavaScriptCore support for ARM64
https://bugs.webkit.org/show_bug.cgi?id=122762

Attachment 214165: Assembler and disassembler changes
https://bugs.webkit.org/attachment.cgi?id=214165&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214165&action=review


>> Source/JavaScriptCore/assembler/ARM64Assembler.h:497
>> +	    S
> 
> enum members should use InterCaps with an initial capital letter. 
[readability/enum_casing] [4]

Thi should really have a name beyond "S"

>> Source/JavaScriptCore/assembler/ARM64Assembler.h:2886
>> +	    return expected &&
> 
> Boolean expressions that span multiple lines should have their operators on
the left side of the line instead of the right side.  [whitespace/operators]
[4]

Can you file a bug on style errors like this, they're gratuitous and i suspect
a byproduct of an absence of a style checker being run on this code :-/