[webkit-reviews] review granted: [Bug 122704] Baseline JIT should use the DFG's PutById IC : [Attachment 214125] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 122704: Baseline JIT should use the DFG's PutById IC
https://bugs.webkit.org/show_bug.cgi?id=122704

Attachment 214125: the patch
https://bugs.webkit.org/attachment.cgi?id=214125&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214125&action=review


r=me

> Source/JavaScriptCore/jit/JIT.h:229
>	       : m_type(PutById)
>	       , bytecodeIndex(bytecodeIndex)
>	       , hotPathBegin(hotPathBegin)
> +	       , structureToCompare(structureToCompare)
>	       , propertyStorageLoad(propertyStorageLoad)
> -	       , putStructureToCompare(structureToCompare)
>  #if USE(JSVALUE64)
>	       , putDisplacementLabel(displacementLabel)

You said you wanted to remove this constructor.