[webkit-reviews] review granted: [Bug 122645] Transition misc cti_op_* JITStubs to JIT operations : [Attachment 214129] patch 2: with Michael's feedback applied.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 14 09:36:33 PDT 2013


Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 122645: Transition misc cti_op_* JITStubs to JIT operations
https://bugs.webkit.org/show_bug.cgi?id=122645

Attachment 214129: patch 2: with Michael's feedback applied.
https://bugs.webkit.org/attachment.cgi?id=214129&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214129&action=review


r+, with whitespace changes.

> Source/JavaScriptCore/jit/JITOpcodes.cpp:1047
> +

Eliminate this blank line to indicate that the links and subsequent code go
together.

> Source/JavaScriptCore/jit/JITOpcodes.cpp:1064
> +

Dito.

> Source/JavaScriptCore/jit/JITOpcodes.cpp:1134
> +

Dito.


More information about the webkit-reviews mailing list