[webkit-reviews] review denied: [Bug 122716] Broken text rendering when input field has selection. : [Attachment 214133] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 14 02:01:50 PDT 2013
Antti Koivisto <koivisto at iki.fi> has denied peavo at outlook.com's request for
review:
Bug 122716: Broken text rendering when input field has selection.
https://bugs.webkit.org/show_bug.cgi?id=122716
Attachment 214133: Patch
https://bugs.webkit.org/attachment.cgi?id=214133&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=214133&action=review
The test case is missing a file. It also doesn't work on mac (it might by
setting some selection colours) but that's ok. At least it can be tested
exercises the code paths (and can be tested manually on wincairo).
> LayoutTests/ChangeLog:8
> + * fast/text/text-rendering-with-input-selection-expected.html:
Added.
Ref test should have two files: text-rendering-with-input-selection.html and
text-rendering-with-input-selection-expected.html
The test works by generating bitmap from both and comparing them. -expected
should contain something that renders the same exact way as the test case but
does so without hitting the bug.
More information about the webkit-reviews
mailing list