[webkit-reviews] review granted: [Bug 122722] Make absoluteQuads/Rects functions return Vectors : [Attachment 214095] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 13 03:56:53 PDT 2013
Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 122722: Make absoluteQuads/Rects functions return Vectors
https://bugs.webkit.org/show_bug.cgi?id=122722
Attachment 214095: patch
https://bugs.webkit.org/attachment.cgi?id=214095&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214095&action=review
> Source/WebCore/ChangeLog:8
> + No new tests (OOPS!).
OOPS!
> Source/WebCore/dom/Range.cpp:1944
> + Vector<FloatQuad> textQuads =
renderText.absoluteQuadsForRange(startOffset, endOffset);
Could use auto for this.
> Source/WebCore/dom/Range.cpp:1947
> quads.appendVector(textQuads);
Sidenote: I wonder if an appendVector(Vector&&) would be a useful optimization.
> Source/WebCore/rendering/RenderText.cpp:261
> void RenderText::absoluteRects(Vector<IntRect>& rects, const LayoutPoint&
accumulatedOffset) const
I wish this method were called collectAbsoluteRects() or something like that.
Same whine for the other similarly named ones.
More information about the webkit-reviews
mailing list