[webkit-reviews] review denied: [Bug 122716] Broken text rendering in some cases. : [Attachment 214086] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied peavo at outlook.com's request for
review:
Bug 122716: Broken text rendering in some cases.
https://bugs.webkit.org/show_bug.cgi?id=122716

Attachment 214086: Patch
https://bugs.webkit.org/attachment.cgi?id=214086&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=214086&action=review


This needs a test case. It should be easy to make one as a ref test. See tests
with -expected.html under LayoutTests/fast/text/ for example.

r- because lack of test case or even information how to reproduce the bug.

> Source/WebCore/ChangeLog:3
> +	   Broken text rendering in some cases.

What cases? The bug description doesn't say either.

> Source/WebCore/rendering/InlineTextBox.cpp:551
> -    TextPaintStyle selectionPaintStyle =
computeTextSelectionPaintStyle(textPaintStyle, renderer(), lineStyle,
paintInfo, paintSelectedTextOnly, paintSelectedTextSeparately,
selectionShadow);
> -
> +    TextPaintStyle selectionPaintStyle =
computeTextSelectionPaintStyle(textPaintStyle, renderer(), lineStyle,
paintInfo, haveSelection, paintSelectedTextOnly, paintSelectedTextSeparately,
selectionShadow);

Instead of adding an extra boolean parameter it would be better to just not
call computeTextSelectionPaintStyle if haveSelection is false.