[webkit-reviews] review granted: [Bug 122604] WebViews inside OS X screen savers have large caches, but should not : [Attachment 213984] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Roben (:aroben)
<aroben at webkit.org>'s request for review:
Bug 122604: WebViews inside OS X screen savers have large caches, but should
not
https://bugs.webkit.org/show_bug.cgi?id=122604

Attachment 213984: Patch
https://bugs.webkit.org/attachment.cgi?id=213984&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213984&action=review


> Source/WebKit/mac/WebView/WebPreferences.mm:134
> +	   if (contains(documentViewerIDs, sizeof(documentViewerIDs) /
sizeof(documentViewerIDs[0]), bundleID))
> +	       return WebCacheModelDocumentViewer;
> +	   if (contains(documentBrowserIDs, sizeof(documentBrowserIDs) /
sizeof(documentBrowserIDs[0]), bundleID))
> +	       return WebCacheModelDocumentBrowser;
> +	   if (contains(primaryWebBrowserIDs, sizeof(primaryWebBrowserIDs) /
sizeof(primaryWebBrowserIDs[0]), bundleID))
> +	       return WebCacheModelPrimaryWebBrowser;

As long as you were modernizing, you could have used WTF_ARRAY_LENGTH here.