[webkit-reviews] review granted: [Bug 122698] Change callOnMainThread to take an std::function : [Attachment 214063] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 12 16:26:49 PDT 2013
Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 122698: Change callOnMainThread to take an std::function
https://bugs.webkit.org/show_bug.cgi?id=122698
Attachment 214063: Patch
https://bugs.webkit.org/attachment.cgi?id=214063&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214063&action=review
>> Source/WTF/wtf/MainThread.cpp:240
>> + callOnMainThread(+callFunctionObject,
std::make_unique<std::function<void ()>>(std::move(function)).release());
>
> Extra space before ( in function call [whitespace/parens] [4]
What does the "+" here mean? Whatever it means, it seems that Windows does not
understand it:
1>..\wtf\MainThread.cpp(240): error C2675: unary '+' :
'WTF::`anonymous-namespace'::<lambda0>' does not define this operator or a
conversion to a type acceptable to the predefined operator
More information about the webkit-reviews
mailing list