[webkit-reviews] review granted: [Bug 118520] Move PlatformCertificateInfo to WebCore and make the ResourceResponse primitives work in terms of that platform agnostic object : [Attachment 213874] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 118520: Move PlatformCertificateInfo to WebCore and make the
ResourceResponse primitives work in terms of that platform agnostic object
https://bugs.webkit.org/show_bug.cgi?id=118520

Attachment 213874: Patch
https://bugs.webkit.org/attachment.cgi?id=213874&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213874&action=review


> Source/WebCore/platform/network/CertificateInfo.h:67
> +    // Certificate chain is normally part of NS/CFURLResponse, but there is
no way to re-add it to a deserialized response after IPC.

I don't think this comment makes any sense.

> Source/WebCore/platform/network/soup/ResourceError.h:60
> +    unsigned tlsErrors() const { return m_certificateInfo.tlsErrors(); }
> +    void setTLSErrors(unsigned tlsErrors) {
m_certificateInfo.setTLSErrors(static_cast<GTlsCertificateFlags>(tlsErrors)); }

> +    GTlsCertificate* certificate() const { return
m_certificateInfo.certificate(); }
> +    void setCertificate(GTlsCertificate* certificate) {
m_certificateInfo.setCertificate(certificate); }

Can't we get rid of these and just use calls on m_certificateInfo directly?

> Source/WebKit2/Shared/API/c/mac/WKCertificateInfoMac.mm:36
> +    RefPtr<WebCertificateInfo> certificateInfo =
WebCertificateInfo::create(WebCore::CertificateInfo(certificateChain));

Please add using directive for the WebCore namespace so you don't have to use
the WebCore prefix here.

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:564
> +

Extra newline.