[webkit-reviews] review granted: [Bug 122666] Fix handling of indirect stackmap locations in FTL OSR exit : [Attachment 214008] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 11 16:55:30 PDT 2013


Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 122666: Fix handling of indirect stackmap locations in FTL OSR exit
https://bugs.webkit.org/show_bug.cgi?id=122666

Attachment 214008: the patch
https://bugs.webkit.org/attachment.cgi?id=214008&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214008&action=review


r=me

> Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:70
> +    jit.push(GPRInfo::regT0);

Might be good to comment why we're seemingly randomly pushing here.


More information about the webkit-reviews mailing list