[webkit-reviews] review granted: [Bug 122462] sunspider-1.0/math-spectral-norm.js.dfg-eager occasionally fails with Trap 5 (i.e int $3) : [Attachment 214033] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 122462: sunspider-1.0/math-spectral-norm.js.dfg-eager occasionally fails
with Trap 5 (i.e int $3)
https://bugs.webkit.org/show_bug.cgi?id=122462

Attachment 214033: the patch
https://bugs.webkit.org/attachment.cgi?id=214033&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214033&action=review


r=me

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:342
> +	       // we've proven for this node wouldn't widen the proof. If so,
then we cannot

Aren't we checking if it *would* widen the proof, and then skipping over if it
does? As I understand it, proofs are supposed to get narrower and narrower as
we prove more and more things, right?