[webkit-reviews] review denied: [Bug 122627] DFG: Add JIT support for LogicalNot(String/StringIdent) : [Attachment 214021] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Nadav Rotem <nrotem at apple.com>'s
request for review:
Bug 122627: DFG: Add JIT support for  LogicalNot(String/StringIdent)
https://bugs.webkit.org/show_bug.cgi?id=122627

Attachment 214021: Patch
https://bugs.webkit.org/attachment.cgi?id=214021&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214021&action=review


> LayoutTests/js/script-tests/dfg-not-string.js:15
> +
> +function foo(text) {
> +  return !!text
> +}
> +
> +var sum = 0;
> +var str = ""
> +for (var i=0; i < 1000; i++) {
> +  sum += foo(str)
> +
> +  if (sum < 10)
> +    str += "a"
> +}
> +
> +dfgShouldBe(foo, "sum", "999");

I think this will deadlock in some cases.  dfgShouldBe()'s second argument
should be an expression that results in a call to the function you pass in the
first argument.