[webkit-reviews] review granted: [Bug 122460] Transition op_new_* JITStubs to JIT operations : [Attachment 214003] patch 2: with Michael's feedback applied.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 122460: Transition op_new_* JITStubs to JIT operations
https://bugs.webkit.org/show_bug.cgi?id=122460

Attachment 214003: patch 2: with Michael's feedback applied.
https://bugs.webkit.org/attachment.cgi?id=214003&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=214003&action=review


r+

> Source/JavaScriptCore/jit/JITInlines.h:1068
> +#undef EABI_32BIT_DUMMY_ARG
> +#undef SH4_32BIT_DUMMY_ARG

This should be inside the #if USE(JSVALUE32_64) / #endif.

Move back to ToT placement for these defines. This puts the #define / #undef
immediately around the use.