[webkit-reviews] review granted: [Bug 122635] Change most call sites to call ICU directly instead of through WTF::Unicode : [Attachment 213968] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 122635: Change most call sites to call ICU directly instead of through
WTF::Unicode
https://bugs.webkit.org/show_bug.cgi?id=122635

Attachment 213968: Patch
https://bugs.webkit.org/attachment.cgi?id=213968&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213968&action=review


Looking at the patch, I now have concerns about readability of the code that
uses ICU directly. Some of their names are not exactly great.

r=me

> Source/WebCore/xml/XPathParser.cpp:77
> +    if (characterTypeMask & (U_GC_M_MASK | U_GC_LM_MASK | U_GC_ND_MASK))

:-/