[webkit-reviews] review canceled: [Bug 118343] [WK2][Soup] Support cache model in NetworkProcess : [Attachment 213006] patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has canceled Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 118343: [WK2][Soup] Support cache model in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=118343

Attachment 213006: patch
https://bugs.webkit.org/attachment.cgi?id=213006&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=213006&action=review


> Source/WebKit2/GNUmakefile.list.am:483
> +	Source/WebKit2/Shared/soup/CacheModelHelper.cpp \
> +	Source/WebKit2/Shared/soup/CacheModelHelper.h \

I'm going to add the new files to cmake buildsystem too.

> Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:38
> +#include <libsoup/soup.h>

ditto

> Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:80
> +    // Despite using system CAs to validate certificates we're
> +    // accepting invalid certificates by default. New API will be
> +    // added later to let client accept/discard invalid certificates.
> +    g_object_set(session, SOUP_SESSION_SSL_USE_SYSTEM_CA_FILE, TRUE,
> +	   SOUP_SESSION_SSL_STRICT, FALSE, NULL);
> +

Now all unix ports use soup, but it won't be true in the future
after Nix will switch to curl. That's why I'm going to add a
USE(SOUP) guard for this block.

> Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:86
> +    if (SoupSessionFeature* soupCache = soup_session_get_feature(session,
SOUP_TYPE_CACHE)) {
> +	   soup_cache_flush(SOUP_CACHE(soupCache));
> +	   soup_cache_dump(SOUP_CACHE(soupCache));
> +    }

ditto