[webkit-reviews] review granted: [Bug 122622] [CSS Shapes] Shape-Image-Threshold should be animatable : [Attachment 213943] Initial Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 10 22:43:41 PDT 2013


Darin Adler <darin at apple.com> has granted Bear Travis <betravis at adobe.com>'s
request for review:
Bug 122622: [CSS Shapes] Shape-Image-Threshold should be animatable
https://bugs.webkit.org/show_bug.cgi?id=122622

Attachment 213943: Initial Patch
https://bugs.webkit.org/attachment.cgi?id=213943&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213943&action=review


> Source/WebCore/rendering/RenderBox.cpp:399
> +	   ShapeOutsideInfo::ensureInfo(this)->dirtyShapeSize();

I am surprised that we would ensureInfo just so we can call dirtyShapeSize. Is
there really something to dirty if there is no info? Is that really how things
work? Did I already ask this in another context?


More information about the webkit-reviews mailing list