[webkit-reviews] review granted: [Bug 122146] Grammar markers are not updated when switching between 1x and 2x : [Attachment 213808] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 122146: Grammar markers are not updated when switching between 1x and 2x
https://bugs.webkit.org/show_bug.cgi?id=122146

Attachment 213808: Patch
https://bugs.webkit.org/attachment.cgi?id=213808&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213808&action=review


> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:108
> -    NSColor *patternColor;
> +    NSColor *patternColor = 0;

You won't need an assert if you take my advice below.

> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:117
> +	       }
> +	       if (!patternColor) {

How about just using else here?

> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:130
> +	       }
> +	       if (!patternColor) {

And here.

> Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm:146
> +	       }
> +	       if (!patternColor) {

And here.