[webkit-reviews] review granted: [Bug 122610] Validate uniform input when setting texture sampler uniforms : [Attachment 213923] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 122610: Validate uniform input when setting texture sampler uniforms
https://bugs.webkit.org/show_bug.cgi?id=122610

Attachment 213923: Patch
https://bugs.webkit.org/attachment.cgi?id=213923&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213923&action=review


> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4170
> +	   for (unsigned ii = 0; ii < v->length(); ++ii) {

Is there a reason for ii vs i here?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4171
> +	       if (((GC3Dint*)v)[ii] >= (int)m_textureUnits.size()) {

Might as well use static_cast

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4189
> +    if (location->type() == GraphicsContext3D::SAMPLER_2D ||
location->type() == GraphicsContext3D::SAMPLER_CUBE)
> +	   for (unsigned ii = 0; ii < (unsigned)size; ++ii) {
> +	       if (((GC3Dint*)v)[ii] >= (int)m_textureUnits.size()) {

Same.