[webkit-reviews] review granted: [Bug 122546] Web Inspector: inspector forgets open navigation sidebar when re-opening : [Attachment 213897] v2

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 122546: Web Inspector: inspector forgets open navigation sidebar when
re-opening
https://bugs.webkit.org/show_bug.cgi?id=122546

Attachment 213897: v2
https://bugs.webkit.org/attachment.cgi?id=213897&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213897&action=review


Looks good. Just some style nits.

> Source/WebInspectorUI/UserInterface/FrameResourceManager.js:86
> +	   var representedObject = (cookie.url) ?
this.resourceForURL(cookie.url) : this.mainFrame;

No need for ( ).

> Source/WebInspectorUI/UserInterface/StorageManager.js:159
> +	       return (matchOnTypeAlone && array.length) ? array[0] : null;

No need for ( ).

> Source/WebInspectorUI/UserInterface/StorageManager.js:179
> +	   if (cookie.type === WebInspector.ContentViewCookieType.DOMStorage)
> +	       return findMatchingObjectInArray(this._domStorageObjects,
function(object) {
> +		   return object.host === cookie.host &&
object.isLocalStorage() === cookie.isLocalStorage;
> +	       });

This needs { } since it is multi-line.

> Source/WebInspectorUI/UserInterface/StorageManager.js:184
> +	   if (cookie.type === WebInspector.ContentViewCookieType.Database)
> +	       return findMatchingObjectInArray(this._databaseObjects,
function(object) {
> +		   return object.host === cookie.host && object.name ===
cookie.name;
> +	       });

Ditto.

> Source/WebInspectorUI/UserInterface/StorageManager.js:192
> +	   if (cookie.type ===
WebInspector.ContentViewCookieType.DatabaseTable)
> +	       return findMatchingObjectInArray(this._databaseObjects,
function(object) {
> +		   return object.host === cookie.host && object.database ===
cookie.name;
> +	       });

Ditto.