[webkit-reviews] review denied: [Bug 122142] Release expired pages in the page cache more often : [Attachment 213862] Patch using timers

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Iago Toral <itoral at igalia.com>'s
request for review:
Bug 122142: Release expired pages in the page cache more often
https://bugs.webkit.org/show_bug.cgi?id=122142

Attachment 213862: Patch using timers
https://bugs.webkit.org/attachment.cgi?id=213862&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
I don't think history items should have the timers.  HistoryItem being so
intertwined with page cache and cached pages is a mistake we'd like to try to
reverse.  Also we don't need multiple timers for this (increasing the size of
history item for something that's used somewhat infrequently)

The page cache itself should have the timer.  When the first CachedPage goes
in, the timer is started.  Additional CachedPages don't change the timer.  And
when the timer fires and one page is purged out, we set it to the expiration of
the next page.