[webkit-reviews] review granted: [Bug 118388] [WK2][Efl][Soup] Make NetworkProcessMainUnix handle proxy settings. : [Attachment 212714] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Csaba Osztrogonac
<ossy at webkit.org>'s request for review:
Bug 118388: [WK2][Efl][Soup] Make NetworkProcessMainUnix handle proxy settings.
https://bugs.webkit.org/show_bug.cgi?id=118388

Attachment 212714: Patch
https://bugs.webkit.org/attachment.cgi?id=212714&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=212714&action=review


I don't know how the soup proxy resolver works, so If EFL devs are fine with
this, it looks good to me too. Please consider moving the soup session
initialization before landing. Thanks

> Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:66
> +    SoupSession* session = WebCore::ResourceHandle::defaultSession();

If we are going to use soup unconditionally in this file, and considering that
there's no other unix port now, maybe it makes more sense to rename this file
as NetworkProcessSoup. Otherwise I would move this line inside the #if block.
In any case, it seems that the Soup session is only used inside the if
(httpProxy), so I would move this line inside the if in any case.