[webkit-reviews] review requested: [Bug 81123] cue.text fails for some track element cues : [Attachment 213890] Simplify hasRequiredFileIdentifier

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 10 09:19:16 PDT 2013


Brendan Long <b.long at cablelabs.com> has asked  for review:
Bug 81123: cue.text fails for some track element cues
https://bugs.webkit.org/show_bug.cgi?id=81123

Attachment 213890: Simplify hasRequiredFileIdentifier
https://bugs.webkit.org/attachment.cgi?id=213890&action=review

------- Additional Comments from Brendan Long <b.long at cablelabs.com>
The last thing that really bothered me in this patch was the substring creation
in hasRequiredFileIdentifier. The new version just walks through the string,
which avoids the copies and ends up simpler anyway. I also made the test use
canplaythrough since the addtrack event was making it flaky. I think I'm
actually done this time.


More information about the webkit-reviews mailing list