[webkit-reviews] review granted: [Bug 122092] ASSERTION FAILED: isHTMLTitleElement(m_titleElement.get()) in WebCore::Document::setTitle : [Attachment 213778] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 122092: ASSERTION FAILED: isHTMLTitleElement(m_titleElement.get()) in
WebCore::Document::setTitle
https://bugs.webkit.org/show_bug.cgi?id=122092

Attachment 213778: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=213778&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213778&action=review


> Source/WebCore/ChangeLog:8
> +	   Remove a bogus assert in Document::setTitle().

This is an incorrect description of what this patch does. The patch removes a
bad cast.

> Source/WebCore/svg/SVGTitleElement.cpp:46
> +    // FIXME: It's possible to register SVGTitleElement to an HTMLDocument.

Sorry, I don’t understand what “register to an HTMLDocument” means, nor do I
understand what we need to fix.