[webkit-reviews] review granted: [Bug 121082] Use unique_ptr instead of deleteAllValues in XPath : [Attachment 213753] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 121082: Use unique_ptr instead of deleteAllValues in XPath
https://bugs.webkit.org/show_bug.cgi?id=121082

Attachment 213753: Patch
https://bugs.webkit.org/attachment.cgi?id=213753&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213753&action=review


> Source/WebCore/xml/XPathExpression.h:53
> +	   XPathExpression(std::unique_ptr<XPath::Expression>);

Could make this explicit for good measure.

> Source/WebCore/xml/XPathNodeSet.h:39
> +	       NodeSet(PassRefPtr<Node> node) : m_isSorted(true),
m_subtreesAreDisjoint(false), m_nodes(1, node) { }

Explicit (if possible).