[webkit-reviews] review granted: [Bug 122548] Add GTK 64 bits release to the buildbot dashboard : [Attachment 213769] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 9 09:44:11 PDT 2013


Darin Adler <darin at apple.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 122548: Add GTK 64 bits release to the buildbot dashboard
https://bugs.webkit.org/show_bug.cgi?id=122548

Attachment 213769: Patch
https://bugs.webkit.org/attachment.cgi?id=213769&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213769&action=review


> Tools/ChangeLog:8
> +	   *
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
Added.

Does the image really need to be on a white circle? Wouldn’t it be better to
have it on a transparent background?

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Ma
in.css:140
> +    content: -webkit-image-set(url(../Images/GTK.png) 1x);

Doesn’t seem helpful to use an image set for a single image.


More information about the webkit-reviews mailing list