[webkit-reviews] review granted: [Bug 122540] AX: VoiceOver does not speak aria-expanded state on iOS : [Attachment 213756] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 122540: AX: VoiceOver does not speak aria-expanded state on iOS
https://bugs.webkit.org/show_bug.cgi?id=122540

Attachment 213756: patch
https://bugs.webkit.org/attachment.cgi?id=213756&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
I've observed you're not exposing canSetExpandedAttribute() at all in this IOS
wrapper, which is something you do in the Mac one by means of the
attributeName() method:

    - (BOOL)accessibilityIsAttributeSettable:(NSString*)attributeName
    {
    [...]
	if ([attributeName isEqualToString:NSAccessibilityDisclosingAttribute])

	    return m_object->canSetExpandedAttribute();
    [...]
    }

In ATK we expose the very same thing with ATK_STATE_EXPANDABLE, so that's it
got my attention. 

Anyway, just pointing it out in case it was not intentional. The current patch
is Ok in any case.