[webkit-reviews] review requested: [Bug 81123] cue.text fails for some track element cues : [Attachment 213743] Use m_state to simplify BOM and Finished handling.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 8 19:40:33 PDT 2013
Brendan Long <b.long at cablelabs.com> has asked for review:
Bug 81123: cue.text fails for some track element cues
https://bugs.webkit.org/show_bug.cgi?id=81123
Attachment 213743: Use m_state to simplify BOM and Finished handling.
https://bugs.webkit.org/attachment.cgi?id=213743&action=review
------- Additional Comments from Brendan Long <b.long at cablelabs.com>
I spent some time today and got DumpRenderTree working on my Mac again
(apparently it's just broken in debug builds?), so this time I can verify on my
own machine that the tests pass. I removed m_finished and just added a Finished
state. I also added a CheckedBOM state, and moved the BOM check to near the top
of parseBytes, which lets me check for the BOM while I'm still dealing with the
raw data (this is simpler, and much less confusing).
More information about the webkit-reviews
mailing list