[webkit-reviews] review granted: [Bug 122533] Turn EventPath into a real class : [Attachment 213734] Cleanup

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 122533: Turn EventPath into a real class
https://bugs.webkit.org/show_bug.cgi?id=122533

Attachment 213734: Cleanup
https://bugs.webkit.org/attachment.cgi?id=213734&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=213734&action=review


> Source/WebCore/ChangeLog:8
> +	   Since we can't forward-declare typedef, turning EventPath into a
real class helps our defactoring.

The comment about forward-declaring typedef is not necessary. Refactoring
strategies not chosen are not that interesting.

> Source/WebCore/dom/EventDispatcher.h:62
> +    const EventContext& item(size_t i) const { return *m_path[i]; }
> +    EventContext& item(size_t i) { return *m_path[i]; }

The interface is not great. item() is vague and and it is not clear which way
the path goes. But I suppose you plan to improve this later.