[webkit-reviews] review granted: [Bug 115332] [EFL][WK2] Separate dispatch context from WorkQueue. : [Attachment 213647] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 8 16:12:22 PDT 2013
Anders Carlsson <andersca at apple.com> has granted Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 115332: [EFL][WK2] Separate dispatch context from WorkQueue.
https://bugs.webkit.org/show_bug.cgi?id=115332
Attachment 213647: Patch
https://bugs.webkit.org/attachment.cgi?id=213647&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213647&action=review
> Source/WebKit2/Platform/efl/DispatchQueueEfl.cpp:49
> + : m_dispatchQueue(dispatchQueue)
This should be indented.
> Source/WebKit2/Platform/efl/DispatchQueueEfl.cpp:73
> + m_workQueue->ref();
Can't you just make m_workQueue a RefPtr?
More information about the webkit-reviews
mailing list