[webkit-reviews] review granted: [Bug 122525] Refined power management in SunSpider 1.0.2 : [Attachment 213721] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 122525: Refined power management in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122525

Attachment 213721: Patch
https://bugs.webkit.org/attachment.cgi?id=213721&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=213721&action=review


> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:60
> +function next() 

Bonus space!

> PerformanceTests/SunSpider/resources/driver-TEMPLATE.html:71
> +	   for (var start = new Date; new Date - start < warmup; ) { }

This busy loop will churn through a lot of object creation – I wonder if it
might be worth having a loop body containing math to spin up the CPU without
also creating artificial GC pressure?