[webkit-reviews] review requested: [Bug 81123] cue.text fails for some track element cues : [Attachment 213723] Fix BOM and add NULL check for m_parser
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 8 15:02:36 PDT 2013
Brendan Long <b.long at cablelabs.com> has asked for review:
Bug 81123: cue.text fails for some track element cues
https://bugs.webkit.org/show_bug.cgi?id=81123
Attachment 213723: Fix BOM and add NULL check for m_parser
https://bugs.webkit.org/attachment.cgi?id=213723&action=review
------- Additional Comments from Brendan Long <b.long at cablelabs.com>
There were two remaining problems: Because this patch converts to a String
up-front, the BOM gets converted to a UTF-16 BOM (0xFEFF instead of 0xEFBBBF).
This solution handles that comparing against String::fromUTF8(xEFxBBFF). I
could do a more complicated version if you think it's important to explicitly
check the original data for 0xEFBBFF. The other problem was that I didn't check
if m_parser existed before using it in TrackLoader::notifyFinished().
More information about the webkit-reviews
mailing list